C++ get method - returning by value or by reference

c++ reference return-value return-value-optimization
Yippie-Ki-Yay picture Yippie-Ki-Yay · May 30, 2010 · Viewed 10.7k times · Source

I've go a very simple question, but unfortunately I can't figure the answer myself.

Suppose I've got some data structure that holds settings and acts like a settings map. I have a GetValue(const std::string& name) method, that returns the corresponding value.

Now I'm trying to figure out - what kind of return-value approach would be better. The obvious one means making my method act like

std::string GetValue(const std::string& name) const

and return a copy of the object and rely on RVO in performance meanings.

The other one would mean making two methods

std::string& GetValue(...)
const std::string& GetValue(...) const

which generally means duplicating code or using some evil constant casts to use one of these routines twice.

#Q

What would be your choice in this kind of situation and why?

Answer

fredoverflow picture fredoverflow · May 30, 2010

That depends on the usage. Should GetValue("foo") = "bar" make sense? In that case, return by value does not do what you want.

Related questions

Store return value of function in reference C++

Is it valid to store the return value of an object in a reference? class A { ... }; A myFunction() { A myObject; return myObject; } //myObject goes out of scope here void mySecondFunction() { A& mySecondObject = myFunction(); } Is it possible to do this …

Read More
Should accessors return values or constant references?

Suppose I have a class Foo with a std::string member str. What should get_str return? std::string Foo::get_str() const { return str; } or const std::string& Foo::get_str() const { return str; } What is more idiomatic …

Read More
What are the differences between a pointer variable and a reference variable in C++?

I know references are syntactic sugar, so code is easier to read and write. But what are the differences?

Read More