How to safely dismiss DialogFragment in onstop()?

android android-dialogfragment dialogfragment
Wayne picture Wayne · May 30, 2013 · Viewed 13.6k times · Source

I need to dismiss DialogFragment in onStop() of an FragmentActivity if it is showing, this is what I did

if(mAlertDlg != null && mAlertDlg.getDialog() != null)
    mAlertDlg.dismiss();

But I usually got IllegalStateException. So please tell me why that code is wrong and what is the correct way to dismiss DialogFragment in onStop()? Thank you.

Answer

Nicolas Jafelle picture Nicolas Jafelle · May 30, 2013

You should use dialogFragment.dismissAllowingStateLoss(). As the documentation say for commitAllowingStateLoss():

"Like commit() but allows the commit to be executed after an activity's state is saved. This is dangerous because the commit can be lost if the activity needs to later be restored from its state, so this should only be used for cases where it is okay for the UI state to change unexpectedly on the user."

So for dismissAllowingStateLoss() is the same approach.

Related questions

DialogFragment advantages over AlertDialog

When developing an Android app, I've read that it's recommended to use DialogFragment instead of using directly an AlertDialog to show alerts and confirmations. This is done, for example, on DialogFragment's Documentation: http://developer.android.com/reference/android/app/DialogFragment.…

Read More
BottomSheetDialogFragment - listen to dismissed by user event

How can I listen to a FINAL dismissal of a BottomSheetDialogFragment? I want to save user changes on the final dismissal only... I tried following: Method 1 This only fires, if the dialog is dismissed by swiping it down (not on …

Read More
What is lifecycle of DialogFragment

I could not find proper lifecycle of android.support.v4.app.DialogFragment by searching on Google. I need this for some implementation. As we know DialogFragment has some methods same like Dialog. DialogFragment extends Fragment so its lifecycle is same …

Read More