Difference between "complexity" metric and "complexity / method" metric

sonarqube cyclomatic-complexity
Jérôme Radix picture Jérôme Radix · Apr 25, 2012 · Viewed 15.2k times · Source

In Sonar, for a particular Java class, I see :

Complexity:     830

Complexity /method:     8,1

How could you explain the difference between those two metrics ?

Is "Complexity" the class complexity ?

What is the maximum complexity a class should be under ? I know methods should be less than 10 for method complexity, but what is the maximum class complexity number a class should conform to be considered not complex ?

Thanks.

EDIT

I also look at Cyclomatic-Complexity rule violations in the file.

For a number of methods, sonar says with different complexity numbers (in french) :

"La complexité cyclomatique de la classe est de 28 alors que le maximum autorisé est de 10."

in english :

"The class cyclomatic complexity is 28 but the maximum allowed is 10".

I don't understand why it says "class cyclomatic complexity" as it seems as a "method cyclomatic complexity".

Also, the class in question does not appears on top of the most complex class sorted by average complexity/method, as sonar says it has only 8,1 average method complexity.

Answer

Fabrice - SonarSource Team picture Fabrice - SonarSource Team · Apr 25, 2012

You can have a look at our "Metric Definitions" Wiki page (and more specifically on the "Complexity" section) to know more about the meaning of metrics found in Sonar.

  • "Complexity" is the total complexity of a resource (for a file => sum of the complexities of every class defined in the file)
  • "Complexity / method" is the "Complexity" divided by the number of methods found in the file
  • ... and so on for the other metrics.

Related questions

Reduce Cyclomatic Complexity of Switch Statement - Sonar

I want to reduce cyclomatic complexity of my switch case my code is : public String getCalenderName() { switch (type) { case COUNTRY: return country == null ? name : country.getName() + HOLIDAY_CALENDAR; case CCP: return ccp == null ? name : ccp.getName() + " CCP" + HOLIDAY_CALENDAR; case …

Read More
Sonar cyclomatic complexity rule issue - discourages multiple return statements

For the following piece of code, sonarqube computes the method cyclomatic complexity as 9 String foo() { if (cond1) return a; if (cond2) return b; if (cond3) return c; if (cond4) return d; return e; } I understand as per the rules for …

Read More
SonarQube Exclude a directory

I am trying to exclude a directory from being analyzed by Sonar. I have the following properties defined in my sonar-project.properties file: sonar.sources=src/java sonar.exclusions=src/java/test/****/*.java The directory structure I have is: src/…

Read More