Tuple struct constructor complains about private fields

Grubermensch picture Grubermensch · Jun 8, 2014 · Viewed 8.3k times · Source

I am working on a basic shell interpreter to familiarize myself with Rust. While working on the table for storing suspended jobs in the shell, I have gotten stuck at the following compiler error message:

error: cannot invoke tuple struct constructor with private fields [E0450]
     let jobs = job::JobsList(vec![]);
                ^~~~~~~~~~~~~

It's unclear to me what is being seen as private here. As you can see below, both of the structs are tagged with pub in my module file. So, what's the secret sauce?

mod job {
    use std::fmt;

    pub struct Job {
        jid: isize,
        pid: isize,
        cmd: String,
    }

    pub struct JobsList(Vec<Job>);
}

fn main() {
    let jobs = job::JobsList(vec![]);
}

Answer

huon picture huon · Jun 9, 2014

As the error message suggests, the problem is JobsList has a private field, that is, the Vec<Job> value is inaccessible outside the module that defines the struct. This means that you cannot pattern match on a JobsList value to extract it, and that you cannot construct it directly.

There's two fixes:

  • make the field public pub struct JobsList(pub Vec<Job>);
  • provide a public constructor

    impl JobsList {
        pub fn new(jobs: Vec<Job>) -> JobsList {
            JobsList(jobs)
        }
    }
    

    called like JobsList::new(vec![]).