Rubocop error 'Class definition is too long ruby'

ruby class coding-style rubocop
brg picture brg · Nov 22, 2013 · Viewed 10.1k times · Source

I am getting rubocop error 'Class definition is too long. [236/100]'. My class looks like below:

class SomeClassName
  include HelperModule
  attr_accessor :aaa, :bbb, :ccc

  .... methods .....
end

What might go wrong? The rubocop docs ClassLength says "length of a class exceeds some maximum value". What does it mean?

Answer

ron pastore picture ron pastore · Jan 8, 2014

Yes, this is because the overall lines are considered to be too many by rubucop. I agree classes shouldn't get too long but think that should ultimately be determined by: does the class have a single responsibility, are the methods concise enough, are there methods that could be shared via module, etc... The number/alert is a great warning though. If things in the class look OK, you can add # rubocop:disable ClassLength immediately above the class definition.

Related questions

Difference between a class and a module

I came from Java, and now I am working more with Ruby. One language feature I am not familiar with is the module. I am wondering what exactly is a module and when do you use one, and why use …

Read More
Rails /lib modules and

I am writing a custom wrapper for open_flash_chart plugin. It's placed in /lib and load it as a module in ApplicationController. However, I have some Class hierarchy or smth problem. From any controller I can access open_flash_…

Read More
Ruby: method to print and neat an array

I am not sure if this question is too silly but I haven't found a way to do it. Usually to puts an array in a loop I do this current_humans = [.....] current_humans.each do |characteristic| puts characteristic end …

Read More