Python subprocess.Popen() wait for completion

python subprocess popen
DJMcCarthy12 picture DJMcCarthy12 · Feb 2, 2015 · Viewed 63.7k times · Source

I am writing a small script to serially walk through a directory and run a command on the subdirectories therein.

I am running into a problem however with Popen() that it will walk through the directories and run the desired command without waiting for the previous one to finish. i.e.

for dir in dirs:
    #run command on the directory here.

it kicks off the command for each dir without caring about it afterwards. I want it to wait for the current one to finish, then kick off the next. The tool I am using on the directories is Log2timeline from SANS SIFT which takes quite a while and produces quite a bit of output. I don't care about the output, I just want the program to wait before kicking off the next.

What's the best way to accomplish this?

Thank you!

Answer

Padraic Cunningham picture Padraic Cunningham · Feb 2, 2015

Use Popen.wait:

process = subprocess.Popen(["your_cmd"]...)
process.wait()

Or check_output, check_call which all wait for the return code depending on what you want to do and the version of python.

If you are using python >= 2.7 and you don't care about the output just use check_call.

You can also use call but that will not raise any error if you have a non-zero return code which may or may not be desirable

Related questions

How to use subprocess popen Python

Since os.popen is being replaced by subprocess.popen, I was wondering how would I convert os.popen('swfdump /tmp/filename.swf/ -d') to subprocess.popen() I tried: subprocess.Popen("swfdump /tmp/filename.swf -d") subprocess.Popen("swfdump %s -d" % (…

Read More
Python subprocess/Popen with a modified environment

I believe that running an external command with a slightly modified environment is a very common case. That's how I tend to do it: import subprocess, os my_env = os.environ my_env["PATH"] = "/usr/sbin:/sbin:" + my_env["PATH"] …

Read More
How can I specify working directory for popen

Is there a way to specify the running directory of command in Python's subprocess.Popen()? For example: Popen('c:\mytool\tool.exe', workingdir='d:\test\local') My Python script is located in C:\programs\python Is is possible to run …

Read More