python threading blocks

B_o_b picture B_o_b · Apr 11, 2013 · Viewed 14.5k times · Source

I am trying to write a program which creates new threads in a loop, and doesn't wait for them to finish. As i understand it if i use .start() on the thread, my main loop should just continue, and the other thread will go off and do its work at the same time

However once my new thread starts, the loop blocks until the thread completes. Have I misunderstood how threading works in python, or is there something stupid I'm doing.

here is my code for creating new threads.

def MainLoop():
    print 'started'
    while 1:
        if not workQ.empty():
            newThread = threading.Thread(target=DoWorkItem(), args=())
            newThread.daemon = True
            newThread.start()
        else:
            print 'queue empty'

thanks all

Answer

Janne Karila picture Janne Karila · Apr 11, 2013

This calls the function and passes its result as target:

threading.Thread(target=DoWorkItem(), args=())

Lose the parentheses to pass the function object itself:

threading.Thread(target=DoWorkItem, args=())