Simple PHP strpos function not working, why?

php strpos
Daniel picture Daniel · Feb 1, 2011 · Viewed 42.6k times · Source

Why isn't this standalone code working:

$link = 'https://google.com';
$unacceptables = array('https:','.doc','.pdf', '.jpg', '.jpeg', '.gif', '.bmp', '.png');

foreach ($unacceptables as $unacceptable) {
        if (strpos($link, $unacceptable) === true) {
            echo 'Unacceptable Found<br />';
        } else {
            echo 'Acceptable!<br />';
        }
}

It's printing acceptable every time even though https is contained within the $link variable.

Answer

coreyward picture coreyward · Feb 1, 2011

When in doubt, read the docs:

[strpos] Returns the numeric position of the first occurrence of needle in the haystack string.

So you want to try something more like:

// ...
if (strpos($link, $unacceptable) !== false) {

Because otherwise strpos is returning a number, and you're looking for a boolean true.

Related questions

Using an array as needles in strpos

How do you use the strpos for an array of needles when searching a string? For example: $find_letters = array('a', 'c', 'd'); $string = 'abcdefg'; if(strpos($string, $find_letters) !== false) { echo 'All the letters are found in the string!…

Read More
PHP check if file contains a string

I'm trying to see if a file contains a string that is sent to the page. I'm not sure what is wrong with this code: ?php $valid = FALSE; $id = $_GET['id']; $file = './uuids.txt'; $handle = fopen($file, "r"); if ($…

Read More
Warning: array_push() expects parameter 1 to be array

This is my code, and when I run this function I get this :Warning: array_push() expects parameter 1 to be array However I define $printed as an array prior to starting. $printed = array(); function dayAdvance ($startDay, $endDay, $weekType){ $newdateform = array( …

Read More