What is the real difference between "Bastard Injection" and "Poor Man's Injection"

oop dependency-injection architecture
Sergio Romero picture Sergio Romero · Aug 17, 2011 · Viewed 15.6k times · Source

From the "Dependency Injection in .Net" book I know that the object graph should be created at the Composition Root of the application which makes a lot of sense to me when you are using an IoC container.

In all the applications I've seen when an attempt to use DI is being made, there are always two constructors: the one with the dependencies as parameters and the "default" one with no parameters which in turn calls the other one "newing" up all the dependencies but, in the aforementioned book this is called the "Bastard Injection anti-pattern" and that is what I used to know as "Poor Man's Injection".

Now considering all this, I would say then that "Poor Man's Injection" would be just not using an IoC container and instead coding all the object graph by hand on the said Composition Root.

So my questions are:

  1. Am I understanding these concepts correctly or am I completely off track?
  2. If you still need to register all the dependencies in the IoC container vs. coding them by hand in the exact same Composition Root, what's the real benefit of using an IoC container?
  3. If I have misunderstood what "Poor Man's Injection" really is, could someone please clarify it?

Thanks

Answer

Mark Seemann picture Mark Seemann · Aug 18, 2011

When it comes to DI, there's a lot of conflicting use of terminology out there. The term Poor Man's DI is no exception. To some people, it means one thing and to others it means something different.

One of the things I wanted to do with the book was to supply a consistent pattern language for DI. When it came to all of those terms with conflicting use, I had two options: Come up with a completely new term, or pick the most prevalent use (according to my subjective judgment).

In general, I've preferred to re-use existing terminology instead of making up a completely new (and thus alien) pattern language. That means that in certain cases (such as Poor Man's DI), you may have a different notion of what the name is than the definition given in the book. That often happens with patterns books.

At least I find it reassuring that the book seems to have done its job of explaining exactly both Poor Man's DI and Bastard Injection, because the interpretation given in the O.P. is spot on.

Regarding the real benefit of a DI Container I will refer you to this answer: Arguments against Inversion of Control containers

P.S. 2018-04-13: I'd like to point out that I've years ago come to acknowledge that the term Poor Man's DI does a poor (sic!) job of communicating the essence of the principle, so for years, now, I've instead called it Pure DI.

P.P.S. 2020-07-17: We removed the term Bastard Injection from the second edition. In the second edition we simply use the more general term Control Freak to specify that your code "depend[s] on a Volatile Dependency in any place other than a Composition Root."

Related questions

Why am I getting PHP Fatal error: Uncaught Error: Class 'MyClass' not found?

This works: class MyClass { public $prop = 'hi'; } class Container { static protected $registry = []; public static function get($key){ if(!array_key_exists($key, static::$registry)){ static::$registry[$key] = new $key; } return static::$registry[$key]; } } $obj = Container::get('MyClass'); echo $obj->…

Read More
Dependency Injection & Singleton Design pattern

How do we identify when to use dependency injection or singleton pattern. I have read in lot of websites where they say "Use Dependency injection over singleton pattern". But I am not sure if I totally agree with them. For …

Read More
What is a Pythonic way for Dependency Injection?

Introduction For Java, Dependency Injection works as pure OOP, i.e. you provide an interface to be implemented and in your framework code accept an instance of a class that implements the defined interface. Now for Python, you are able …

Read More