JavaScript confirm cancel button not stopping JavaScript

javascript confirm dialog
RyanPitts picture RyanPitts · Apr 29, 2011 · Viewed 54.5k times · Source

I have a delete button that is tied to some comments on a page i have. When you click the delete button i am trying to get a confirm dialog box to pop up asking if you are sure you want to delete the comment. Clicking OK should run the function to delete the comment and clicking cancel should not run the function but simply close the dialog box.

This is my code:

onclick="confirm('Are you sure that you want to delete this comment?'); commentDelete(1);"

My problem: When i click cancel the delete function still runs. My guess is that the function is still getting called because when i click cancel it just is stepping forward in the JavaScript and calling the function. How can i accomplish this correctly? I know this is probably a simple problem. Thanks for any help!

Answer

Amadan picture Amadan · Apr 29, 2011 
onclick="if (confirm('Are you...?')) commentDelete(1); return false"

You are missing an if. In your version, first you get a question, and then regardless of the answer, you call commentDelete.

Related questions

Can you wait for javascript callback?

I'm trying to use the jQuery alerts dialog library from http://abeautifulsite.net/notebook/87 instead of the default alerts (which look pretty awful in my opinion). This seems to be a great library, but there is not an example of …

Read More
Custom choices in JavaScript confirm dialog

How to write a confirm dialog in JavaScript with custom choices? Instead of just "Ok" and "Cancel", I would like to have for example "This" "That" and "Other".

Read More
Custom confirm dialog with JavaScript

I would like to create a JavaScript function similar to confirm() that shows a dialog (a div with a question and 2 buttons) and returns true if the user clicks "Ok" or false otherwise. Is it possible to do that using …

Read More