Using shareReplay(1) in Angular - still invokes http request?

Royi Namir picture Royi Namir · Jun 26, 2018 · Viewed 14.6k times · Source

I've created a demo (ng-run) where I have a button which invokes an Http request.

When the button is clicked, I invoke this method :

public getData(){
 this._jokeService.getData().subscribe();
}

Which in turn invokes this ( from a service) :

 public getData() {
    return this.http.get(API_ENDPOINT).pipe(shareReplay(1))
  }

The problem is that on every click - I still see a new http request initiated :

enter image description here

Question:

Why doesn't shareReplay keeps the last value of the response?
How can I make my code to invoke the http only once and keep that value for future subscriptions ?

Edit: solution is here

Answer

siva636 picture siva636 · Jun 26, 2018

If you call every time this.http.get(API_ENDPOINT).pipe(shareReplay(1)), each time http request will be triggered. If you want to make http call once and cache data, the following is recommended.

You first get the observable for data:

 ngOninit(){
    this.data$ =  this._jokeService.getData().pipe(shareReplay(1));
    }

Now subscribe multiple times:

 public getData(){
     this.data$.subscribe();
    }

Your service:

public getData() {
    return this.http.get(API_ENDPOINT)
  }