change <a> target to "_blank" depending on href

javascript href target getelementsbytagname
Christian picture Christian · Sep 1, 2010 · Viewed 21.1k times · Source

I'm trying to sort through the links on my page and make some of them open into a new window, depending on their URL. This is the code I have. It doesn't seem to be working. Can you see why?

function MakeMenuLinksOpenInNewWindow() {
    var links = document.getElementsByTagName("a");
    for (var i = 0; i < links.length; i++) {
        if (links[i].href == "http://testtesttest.org/")
            links[i].target = "_blank";
    }
}
MakeMenuLinksOpenInNewWindow();

Answer

Darin Dimitrov picture Darin Dimitrov · Sep 1, 2010

Make sure that when you call this function the DOM has been loaded:

window.onload = MakeMenuLinksOpenInNewWindow;

or:

<body onload="MakeMenuLinksOpenInNewWindow();">

Related questions

Which "href" value should I use for JavaScript links, "#" or "javascript:void(0)"?

The following are two methods of building a link that has the sole purpose of running JavaScript code. Which is better, in terms of functionality, page load speed, validation purposes, etc.? or function myJsFunc() { alert("myJsFunc"); } <a href="javascript:…

Read More
JavaScript function in href vs. onclick

I want to run a simple JavaScript function on a click without any redirection. Is there any difference or benefit between putting the JavaScript call in the href attribute (like this: <a href="javascript:my_function();window.print();">....&…

Read More
window.location.href and window.open () methods in JavaScript

What is the difference between window.location.href and window.open () methods in JavaScript?

Read More