Why Array.prototype.reduce() is not taking an empty array as accumulator?

javascript arrays reduce
segmentationfaulter picture segmentationfaulter · Sep 18, 2015 · Viewed 14.8k times · Source

I am trying to filter all the elements in an array which are bigger than 10 to a new array. I am intentionally not using Array.prototype.filter() since I want to learn the reduce() method. Here is the code I was playing with

I was expecting that filteredArr would be initialized with an empty array at the time of first callback execution as it happens with many examples provided here. But when I run this code, I get the error Cannot read property 'push' of undefined, where am I messing it up? Thank you!

Answer

Paul picture Paul · Sep 18, 2015

When you try to do return filteredArr.push(collectionElement), in essence you are returning length of filteredArr after the push operation. The push() method adds one or more elements to the end of an array and returns the new length of the array. Ref: Array.prototype.push().

You need to return the filteredArr from your anonymous function, so that it is used as the previousValue for the next call

var collection = [3, 5, 11, 23, 1];

// filter all the elements bigger than 10 to a new array

var output = collection.reduce(function(filteredArr, collectionElement) {
  if (collectionElement > 10) {
    filteredArr.push(collectionElement);
  }
  return filteredArr;
}, []);

Related questions

Javascript reduce() on Object

There is nice Array method reduce() to get one value from the Array. Example: [0,1,2,3,4].reduce(function(previousValue, currentValue, index, array){ return previousValue + currentValue; }); What is the best way to achieve the same with objects? I'd like to do this: { a: {…

Read More
Using the reduce function to return an array

Why is it that when I want to use the push function inside the reduce function to return a new array I get an error. However, when I use the concat method inside the reduce function, it returns a new …

Read More
TypeError: this.reduce is not a function

After adding a method to the Array prototype, some other, unrelated script breaks. [Opera] Unhandled Error: 'this.reduce' is not a function [Firefox] TypeError: this.reduce is not a function The method itself works ([1,2,3].xintsum() outputs 6 as expected). // adding a …

Read More