AngularJS filter returning html as string

Jakemmarsh picture Jakemmarsh · Jul 10, 2013 · Viewed 10.3k times · Source

I've created an AngularJS filter to automatically create clickable links from addresses found in data. The filter:

app.filter('parseUrl', function() {
    var  //URLs starting with http://, https://, or ftp://
        replacePattern1 = /(\b(https?|ftp):\/\/[-A-Z0-9+&@#\/%?=~_|!:,.;]*[-A-Z0-9+&@#\/%=~_|])/gim,
        //URLs starting with "www." (without // before it, or it'd re-link the ones done above).
        replacePattern2 = /(^|[^\/])(www\.[\S]+(\b|$))/gim,
        //Change email addresses to mailto:: links.
        replacePattern3 = /(\w+@[a-zA-Z_]+?\.[a-zA-Z]{2,6})/gim;

        return function(text, target, otherProp) {        
            angular.forEach(text.match(replacePattern1), function(url) {
                text = text.replace(replacePattern1, "<a href=\"$1\" target=\"_blank\">$1</a>");
            });
            angular.forEach(text.match(replacePattern2), function(url) {
                text = text.replace(replacePattern2, "$1<a href=\"http://$2\" target=\"_blank\">$2</a>");
            });
            angular.forEach(text.match(replacePattern3), function(url) {
                text = text.replace(replacePattern3, "<a href=\"mailto:$1\">$1</a>");
            });

            return text;        
        };
    });

And here is how I'm calling it (inside a paragraph):

<p><strong>Details:</strong> {{event.description | parseUrl}}</p>

And this works correctly to replace the plain text links with the code for a link. However, it replaces it with the link literally as plain text. For example, www.google.com would get replaced with &lt;a href="http://www.google.com" target="_blank"&gt;http://google.com&lt;/a&gt;. This clearly doesn't make a clickable link, which was my goal.

I'm not sure why this is happening. Any ideas on how to prevent/fix it? Thanks.

Answer

Jollymorphic picture Jollymorphic · Jul 10, 2013

Try using the ngBindHtmlUnsafe directive to have the HTML that your filter produces applied as actual innerHTML contents of an element, like so:

<span ng-bind-html-unsafe="event.description | parseUrl"></span>