Socket, BufferedReader hangs at readLine()

ashim picture ashim · May 13, 2011 · Viewed 26.8k times · Source

I have a server which initially does this:-

BufferedReader br = new BufferedReader(new InputStreamReader(s.getInputStream()));
for (;;) {
  String cmdLine = br.readLine();
  if (cmdLine == null || cmdLine.length() == 0)
     break; 
  ...
}

later it passes the socket to another class "foo" This class wait for application specific messages.

 BufferedReader br = new BufferedReader(new InputStreamReader(s.getInputStream()));
 appCmd=br.readLine();

My client sends this sequence:

  • "bar\n"
  • "how are u?\n"
  • "\n"
  • "passing it to foo\n"
  • "\n"

The problem is that sometimes "foo" does not get its response. It hangs in the readLine().

What is the chance that readLine() in the server is buffering up the data using the read ahead and "foo" class is getting starved?

If I add a sleep in the client side, it works. But what is the chance that it will always work?

  • "bar\n"
  • "how are u?\n"
  • "\n"
  • sleep(1000);
  • "passing it to foo\n"
  • "\n"

How to fix the problem? Appreciate any help on this regard.

Answer

mojado picture mojado · Feb 17, 2014

eee's solution works perfectly. I was trying to read output from an SMTP conversation but it would block on:

while ((response = br.readLine()) != null) {
    ...Do Stuff
}

Changing to:

while (br.ready()) {
    response = br.readLine();
    ...Do Stuff
}

I can read everything just fine. br is a BufferedReader object, BTW.