SonarQube: Invoke method(s) only conditionally

java logging sonarqube
Olezt picture Olezt · Jun 2, 2017 · Viewed 24.1k times · Source

The following part of code raises a major bug at SonarQube : "Invoke method(s) only conditionally."
How am I supposed to fix this?

if(us != null){
    logger.info("Log this: {}", us.toString());
}

Answer

Tibor Blenessy picture Tibor Blenessy · Jun 2, 2017

The call to us.toString() is redundant, toString() method will be called regardless the configured log level. You should pass only us as an argument to info without an if statement.

logger.info("Log this: {}", us);

Related questions

Good examples using java.util.logging

I want to use logs in my program. I heard about java.util.logging, but I don't know how to begin. Are there any examples of what can I do with logging? How would I use logging in my own …

Read More
How to write logs in text file when using java.util.logging.Logger

I have a situation in which I want to write all logs created by me into a text file. We are using java.util.logging.Logger API to generate the logs. I tried: private static Logger logger = Logger.getLogger(className.…

Read More
How to log SQL statements in Spring Boot?

I want to log SQL statements in a file. I have the following properties in application.properties spring.datasource.url=... spring.datasource.username=user spring.datasource.password=1234 spring.datasource.driver-class-name=net.sourceforge.jtds.jdbc.Driver spring.jpa.show-sql=true spring.…

Read More