What is the right position of literals in String Comparison?

java pmd
unj2 picture unj2 · Jun 23, 2010 · Viewed 12k times · Source

I have

if (localName.equals("TaxName")) {

but PMD says

Position literals first in String comparisons

Answer

Adam picture Adam · Jun 23, 2010

"TaxName".equals(localName) is better as if localName is null you won't get a null pointer exception.

Related questions

Avoid printStackTrace(); use a logger call instead

In my application, I am running my code through PMD.It shows me this message: Avoid printStackTrace(); use a logger call instead. What does that mean?

Read More
Iterating over the content of a text file line by line - is there a best practice? (vs. PMD's AssignmentInOperand)

We have a Java Application that has a few modules that know to read text files. They do it quite simply with a code like this: BufferedReader br = new BufferedReader(new FileReader(file)); String line = null; while ((line = br.readLine()) != …

Read More
Logger vs. System.out.println

I'm using the PMD plugin for eclipse and it gives me an error when using System.out.println() with the explanation: System.(out|err).print is used, consider using a logger. My question is - What is a Logger? How …

Read More