Bufferedwriter works, but file empty?

java file bufferedwriter
newnewbie picture newnewbie · Sep 2, 2013 · Viewed 8.3k times · Source

I have the following code:

CSVmaker(LinkedList data) {
    String [] myLines = makeStrings(data);
  //  for (int k = 0; k<myLines.length; k++)
  //  System.out.println(myLines[]);




    this.file = new File("rawdata.csv");
        try {
            BufferedWriter buff = new BufferedWriter(new FileWriter(file));
            for (int i = 0; i<myLines.length; i++){
                buff.write(myLines[i]);
                buff.newLine();
                System.out.println("done");
            }
        } catch (IOException ex) {
          System.out.println("except");
        }



}

No, I checked for the contents of myLines, these are correct.

Also, I get the print which prints "done" just as often as I should. The csv is created.

However, if I open it manually, it is empty.

What can be the reason for this?

Answer

nanofarad picture nanofarad · Sep 2, 2013

You never flush the buffer, or close the BufferedWriter.

After the for loop, make the following calls:

buff.flush();
buff.close();

Even with other resources, closing them when done is a good idea.

Related questions

Java - how do I write a file to a specified directory

I want to write a file results.txt to a specific directory on my machine (Z:\results to be precise). How do I go about specifying the directory to BufferedWriter/FileWriter? Currently, it writes the file successfully but to the …

Read More
how to write an array to a file Java

I have been trying to write an array to a file. I know how to write integers or String to a file but to bring an array confuses me. I am using this right now: public static void write (String …

Read More
Is it necessary to close a FileWriter, provided it is written through a BufferedWriter?

Consider a BufferedReader as below: writer = new BufferedWriter(new FileWriter(new File("File.txt"), true)); In this case at the end of the application, I am closing the writer with writer.close() Will this be enough? Won't that FileWriter created …

Read More