FileWriter in java not writing to txt file

user2540802 picture user2540802 · Jul 19, 2013 · Viewed 34.7k times · Source

I am trying to get input from a JOptionPane and store what the user typed into a text file using the FileWriter class.To make sure that the input from what the user typed was being stored I wrote a system.out and what I typed in the JOptionPane appears. Unfortunately when I open the .txt file nothing I entered appears! By the way, the file path I entered is correct.

Here is my code. HELP ME!

String playername = JOptionPane.showInputDialog("What Will Be Your Character's Name?");
System.out.println(playername);
try {
    FileWriter charectersname = new FileWriter("/Users/AlecStanton/Desktop/name.txt/");
    BufferedWriter out = new BufferedWriter(charectersname);
    out.write(playername);
    }
catch (IOException e) {
     // TODO Auto-generated catch block
     e.printStackTrace();
}

Answer

Brian Agnew picture Brian Agnew · Jul 19, 2013

Buffered writers will only write out when they're full or when they're being closed (hence the name Buffered).

So you can do this:

out.close();

which will flush the buffer and then close it. If you only wanted to flush it but keep it open for further writes (e.g. imagine you're writing a log file), you could do:

out.flush();

You'd likely want to do this when finishing up with such a resource. e.g.

BufferedWriter out = ...
try {
   out.write(...);
}
catch (Exception e) {
   // ..
}
finally {
   out.close();
}

Or possibly using the try-with-resources constructs in Java 7, which (frankly) is more reliable to write code around.