Checking if a collection is empty in Java: which is the best method?

java collections is-empty
Vikrant picture Vikrant · Jun 22, 2012 · Viewed 178.9k times · Source

I have two ways of checking if a List is empty or not

if (CollectionUtils.isNotEmpty(listName))

and 

if (listName != null && listName.size() != 0)

My arch tells me that the former is better than latter. But I think the latter is better.

Can anyone please clarify it?

Answer

Jon Skeet picture Jon Skeet · Jun 22, 2012

You should absolutely use isEmpty(). Computing the size() of an arbitrary list could be expensive. Even validating whether it has any elements can be expensive, of course, but there's no optimization for size() which can't also make isEmpty() faster, whereas the reverse is not the case.

For example, suppose you had a linked list structure which didn't cache the size (whereas LinkedList<E> does). Then size() would become an O(N) operation, whereas isEmpty() would still be O(1).

Additionally of course, using isEmpty() states what you're actually interested in more clearly.

Related questions

Initialization of an ArrayList in one line

I wanted to create a list of options for testing purposes. At first, I did this: ArrayList<String> places = new ArrayList<String>(); places.add("Buenos Aires"); places.add("Córdoba"); places.add("La Plata"); Then, I …

Read More
How do I efficiently iterate over each entry in a Java Map?

If I have an object implementing the Map interface in Java and I wish to iterate over every pair contained within it, what is the most efficient way of going through the map? Will the ordering of elements depend on …

Read More
How to make a new List in Java

We create a Set as: Set myset = new HashSet() How do we create a List in Java?

Read More