Cannot find protocol declaration for

Ben Thompson picture Ben Thompson · Apr 15, 2012 · Viewed 36.8k times · Source

I have two objects, both of which are view controllers. The first (Ill call it viewController1) declares a protocol. The second (which unsurprisingly I will name viewController2) conforms to this protocol.

XCode is giving me a build error of: 'Cannot find protocol declaration for viewController1'

I have seen various questions on this subject and I am certain it is to do with a loop error, but I just can't see it in my case...

Code below..

viewController1.h

@protocol viewController1Delegate;

#import "viewController2.h"

@interface viewController1 {

}

@end

@protocol viewController1Delegate <NSObject>

// Some methods

@end

viewController2.h

#import "viewController1.h"

@interface viewController2 <viewController1Delegate> {

}

@end

Initially, I had the import line in viewController1 above that of the protocol declaration. This was preventing the project from building at all. After searching on SO, I realised the problem and switched the two lines around. I am now getting a warning (as opposed to an error). The project builds fine and actually runs perfectly. But I still feel there must be something wrong to be given a warning.

Now, as far as I can see, when the compiler gets to viewController1.h, the first thing it sees is the declaration of the protocol. It then imports the viewController.h file and sees this implements this protocol.

If it were compiling them the other way around, it would look at viewController2.h first, and the first thing it would do is import viewController1.h the first line of which is the protocol declaration.

Am I missing something?

Answer

Costique picture Costique · Apr 15, 2012

Remove this line from viewController1.h:

#import "viewController2.h"

The problem is that viewController2's interface is preprocessed before the protocol declaration.

The general structure of the file should be like this:

@protocol viewController1Delegate;
@class viewController2;

@interface viewController1
@end

@protocol viewController1Delegate <NSObject>
@end