Questionnaire/Checklist for Bitbucket Pullrequest reviewers
I am trying to see if I can enforce a questionnaire in Bitbucket before reviewers approve a Pull-request. Sample questions that I would like to use are..
- If the changes made are to a global repository shared among many regions, did you check with the reviewers if he/she informed the global team or any particular individuals?
- Did you check variable naming conventions?
- Are there enough comments around any complex logic?
- Are there enough unit tests around the new logic and where it is relevant, did you check the code coverage report?
These are just some sample questions and some of them of course can be monitored using various plugins during the build process or in Sonar etc, but there are always things where we have no immediate way of automating, like the first sample question above. So, until they can be automated, I at least want to make sure those questions are addressed before a pull-request is approved.
Question: Has anybody thought of a similar situation and found any support directly with in Bitbucket or using any plugins? My quick google search didn't yield any useful results
Answer
The Scriptrunner add-on reports being able to create tasks within a pull request when the pull request is created.
You can also watch and vote for the feature suggestion for adding the behaviour as core on jira.atlassian.com.
That said, it is a somewhat unusual request in that it may be adding process overhead too late in the process. The things you list as tasks would, to me, be things that should be checked (hopefully as a matter of course) before creating a pull request, and that reviewers would call out as missing as part of their review.
Disclosure: I work for Atlassian