How to modify Github pull request？

git github pull-request
flygoast picture flygoast · May 25, 2013 · Viewed 60.7k times · Source

I've opened a pull request to a project. The maintainer has decided to accept it, but told me to modify some contents.

How can I do it? Whether I should keep the commit hash unchanged, how can I do it?

Answer

Daij-Djan picture Daij-Djan · May 25, 2013

Just push more commits on to the branch the request is for. The pull request will pick this up then.

Example:

If you want to have b merged into master

  1. You push c1,c2,c3 to b
  2. then you make a new request for b
  3. it gets reviewed and you need more commits
  4. You push c11,c21,c31 to b
  5. The pull request now shows all 6 six commits

Related questions

How do I update a GitHub forked repository?

I recently forked a project and applied several fixes. I then created a pull request which was then accepted. A few days later another change was made by another contributor. So my fork doesn't contain that change. How can I …

Read More
Can you issue pull requests from the command line on GitHub?

It seems like you have to interact with github.com to initiate a pull request. Is this so?

Read More
Undo a merge by pull request?

Someone accepted a pull request which they shouldn't have. Now we have a bunch of broken code merged in. How do you undo a pull request? I was just going to revert the changes to the commit just before the …

Read More