Should I avoid multi-table (concrete) inheritance in Django by any means?

utapyngo picture utapyngo · May 5, 2014 · Viewed 8.6k times · Source

Many experienced developers recommend against using Django multi-table inheritance because of its poor performance:

  1. Django gotcha: concrete inheritance by Jacob Kaplan-Moss, a core contributor of Django.

    In nearly every case, abstract inheritance is a better approach for the long term. I’ve seen more than few sites crushed under the load introduced by concrete inheritance, so I’d strongly suggest that Django users approach any use of concrete inheritance with a large dose of skepticism.

  2. Two Scoops of Django by Daniel Greenfield (@pydanny)

    Multi-table inheritance, sometimes called “concrete inheritance,” is considered by the authors and many other developers to be a bad thing. We strongly recommend against using it.

    At all costs, everyone should avoid multi-table inheritance since it adds both confusion and substantial overhead. Instead of multi-table inheritance, use explicit OneToOneFields and ForeignKeys between models so you can control when joins are traversed.

But without multi-table inheritance, I can't easily

  1. Reference base model in another model (have to use GenericForeignKey or reverse dependency);

  2. Get all instances of base model.

    (feel free to add more)

So what is wrong with this kind of inheritance in Django? Why are explicit OneToOneFields better?

How much does performance suffer from JOINs? Are there any benchmarks that show the difference in performance?

Does not select_related() allow us to control when JOINs are invoked?


I have moved concrete examples to a separate question since this one is becoming too broad, and added a list of reasons for using multi-table inheritance instead.

Answer

dani herrera picture dani herrera · May 8, 2014

First of all, inheritance has not a natural translation to relational database architecture (ok, I know, Oracle Type Objects and some other RDBMS support inheritance but django don't take advantage of this functionality )

At this point, notice than django generates new tables to subclasses and write lots of left joins to retrieve data from this 'sub-tables'. And left joins are not your friends. In an high performance scenario, like a game backend or something else, you should avoid it and resolve inheritance 'by hand' with some artifaces like nulls, OneToOne or foreign keys. In OneToOne scenario, you can call related table directly or only if you need it.

... BUT ...

"In my opinion (TGW)" you should to include model inheritance in your enterprise projects when it catch to your universe of discourse. I do this and I save a lot of development hours to my customers thanks to this feature. Also code becomes clean and elegant and that means easy maintenance ( notice than this kind of projects don't have hundreds or requests by second )

Question by question

Q: What is wrong with this kind of inheritance in Django?
A: Lot of tables, lot of left joins.

Q: Why are explicit OneToOneFields better?
A: You can access directly to related model without left joins.

Q: Are there any illustrative examples (benchmarks)?
A: No comparable.

Q: Does not select_related() allow us to control when JOINs are invoked?
A: django joins needed tables.

Q: What are the alternatives to multi-table inheritance when I need to reference a base class in another model?
A: Nullification. OneToOne relations and lots of code lines. It depends of application needs.

Q: Are GenericForeignKeys better in this case?
A: No for me.

Q: What if I need OneToOneField to base model? A: Write it. There is no problem with this. For example, you can extend User model and also you can have a OneToOne to User base model for some users.

Conclusion

You should to know the cost of write and maintenance code without model inheritance also cost of hardware to support model inheritance applications and act accordingly.