strncpy overwrites existing character string

c strncpy
stan picture stan · Sep 10, 2011 · Viewed 8.7k times · Source

I've created a function to convert a number into a roman numeral. I know the logic of the conversion itself is correct, however, each time strncpy is called, it overwrites the previous value of "rom". I even tried calling it back to back and it only returned the latter.

Here's a snippet from the code:

   char* rom = (char*) calloc (10,sizeof(char));

    while(intval>=1000){
        intval -= 1000;
    strncpy(rom,"M",2);
    }

Maybe using calloc is part of the issue, but I tried using malloc and it gave me the same result.

Answer

Foo Bah picture Foo Bah · Sep 10, 2011

you want to append, but strcpy just copies to the address (and overwrites). use strcat or strncat

Related questions

Why should you use strncpy instead of strcpy?

Edit: I've added the source for the example. I came across this example: char source[MAX] = "123456789"; char source1[MAX] = "123456789"; char destination[MAX] = "abcdefg"; char destination1[MAX] = "abcdefg"; char *return_string; int index = 5; /* This is how strcpy works */ printf("destination is …

Read More
Why does strncpy not null terminate?

strncpy() supposedly protects from buffer overflows. But if it prevents an overflow without null terminating, in all likelihood a subsequent string operation is going to overflow. So to protect against this I find myself doing: strncpy( dest, src, LEN ); dest[…

Read More
Why are strlcpy and strlcat considered insecure?

I understand that strlcpy and strlcat were designed as secure replacements for strncpy and strncat. However, some people are still of the opinion that they are insecure, and simply cause a different type of problem. Can someone give an example …

Read More