Switch statement with returns -- code correctness

c switch-statement correctness
houbysoft picture houbysoft · Jun 17, 2010 · Viewed 120.1k times · Source

Let's say I have code in C with approximately this structure:

switch (something)
{
    case 0:
      return "blah";
      break;

    case 1:
    case 4:
      return "foo";
      break;

    case 2:
    case 3:
      return "bar";
      break;

    default:
      return "foobar";
      break;
}

Now obviously, the breaks are not necessary for the code to run correctly, but it sort of looks like bad practice if I don't put them there to me.

What do you think? Is it fine to remove them? Or would you keep them for increased "correctness"?

Answer

kgiannakakis picture kgiannakakis · Jun 17, 2010

Remove the break statements. They aren't needed and perhaps some compilers will issue "Unreachable code" warnings.

Related questions

How can I compare strings in C using a `switch` statement?

In C there is a switch construct which enables one to execute different conditional branches of code based on an test integer value, e.g., int a; /* Read the value of "a" from some source, e.g. user input */ switch (…

Read More
Switch statement: must default be the last case?

Consider the following switch statement: switch( value ) { case 1: return 1; default: value++; // fall-through case 2: return value * 2; } This code compiles, but is it valid (= defined behavior) for C90/C99? I have never seen code where the default case is not the last …

Read More
Using continue in a switch statement

I want to jump from the middle of a switch statement, to the loop statement in the following code: while (something = get_something()) { switch (something) { case A: case B: break; default: // get another something and try again continue; } // do something …

Read More