copying the contents of a binary file

c filehandle copying
Gan picture Gan · May 3, 2010 · Viewed 11.2k times · Source

I am designing an image decoder and as a first step I tried to just copy the using c. i.e open the file, and write its contents to a new file. Below is the code that I used.

while((c=getc(fp))!=EOF)
  fprintf(fp1,"%c",c);

where fp is the source file and fp1 is the destination file. The program executes without any error, but the image file(".bmp") is not properly copied. I have observed that the size of the copied file is less and only 20% of the image is visible, all else is black. When I tried with simple text files, the copy was complete.

Do you know what the problem is?

Answer

unwind picture unwind · May 3, 2010

Make sure that the type of the variable c is int, not char. In other words, post more code.

This is because the value of the EOF constant is typically -1, and if you read characters as char-sized values, every byte that is 0xff will look as the EOF constant. With the extra bits of an int; there is room to separate the two.

Related questions

How do I determine the size of my array in C?

How do I determine the size of my array in C? That is, the number of elements the array can hold?

Read More
How to initialize all members of an array to the same value?

I have a large array in C (not C++ if that makes a difference). I want to initialize all members of the same value. I could swear I once knew a simple way to do this. I could use memset() …

Read More
Convert char to int in C and C++

How do I convert a char to an int in C and C++?

Read More