strcat implementation

c strcat
skydoor picture skydoor · Mar 21, 2010 · Viewed 50.1k times · Source

I tried to implement the strcat by myself, and I found the strcat implementation from Wiki like this......but when I use it, there is segmentation fault.

What's wrong with the code below?

char *
strcat(char *dest, const char *src)
{
    size_t i,j;
    for (i = 0; dest[i] != '\0'; i++)
        ;
    for (j = 0; src[j] != '\0'; j++)
        dest[i+j] = src[j];
    dest[i+j] = '\0';
    return dest;
}

Answer

Pavel Radzivilovsky picture Pavel Radzivilovsky · Mar 21, 2010

the code is okay.

Looks like you have a problem in the calling code.

Did you remember to allocate enough memory for the target string?

Related questions

error: function returns address of local variable

I'm beginner with C and I am learning on my own. I am creating the following function: char *foo(int x){ if(x < 0){ char a[1000]; char b = "blah"; x = x - 1; char *c = foo(x); strcpy(a, b); strcat(…

Read More
How to find the length of argv[] in C

#include <stdio.h> #include <stdlib.h> #include <string.h> int main(int argc, char *argv[]){ int fir; //badly named loop variable char *input[] = calloc( strlen(argv), sizeof(char)); //initializing an array for( fir = 1; fir&…

Read More
strcat concat a char onto a string?

Using GDB, I find I get a segmentation fault when I attempt this operation: strcat(string,&currentChar); Given that string is initialized as char * string = ""; and currentChar is char currentChar = 'B'; Why does this result in a segmentation fault? …

Read More