C++'s pure virtual function implementation and header files

Neo picture Neo · Jan 13, 2011 · Viewed 36.2k times · Source

I'm having some trouble implementing pure virtual functions inherited from some abstract class, when the classes in question are divided into *.h and *.cpp files. The compiler (g++) tells me that the derived class cannot be instantiated because of the existence of pure functions.

/** interface.h**/
namespace ns
{
    class Interface {
        public:
            virtual void method()=0;
    }
}

/** interface.cpp**/
namespace ns
{
    //Interface::method()() //not implemented here
}

/** derived.h **/
namespace ns
{
    class Derived : public Interface {
        //note - see below
    }
}

/** derived.cpp **/
namespace ns
{
    void Derived::Interface::method() { /*doSomething*/ }
}

/** main.cpp **/
using namespace ns;
int main()
{
    Interface* instance = new Derived; //compiler error
}

Does this mean that I have to declare the method() twice - in the Interface's *.h and in the derived.h too? Is there no other way around?

Answer

Lightness Races in Orbit picture Lightness Races in Orbit · Jan 13, 2011

You forgot to declare Derived::method().

You tried to define it at least, but wrote Derived::Interface::method() rather than Derived::method(), but you did not even attempt to declare it. Therefore it doesn't exist.

Therefore, Derived has no method(), therefore the pure virtual function method() from Interface was not overridden... and therefore, Derived is also pure virtual and cannot be instantiated.

Also, public void method()=0; is not valid C++; it looks more like Java. Pure virtual member functions have to actually be virtual, but you did not write virtual. And access specifiers are followed by a colon:

public:
    virtual void method() = 0;