Converting QString to std::string

Steve The Squid picture Steve The Squid · Aug 19, 2013 · Viewed 15.4k times · Source

I've seen several other posts about converting QString to std::string, and it should be simple. But somehow I'm getting an error.

My code is compiled into a VS project using cmake (I'm using VS express), so there's no issue with the QT libraries, and the GUI that I wrote works besides this part.

I have a QComboBox cb that holds the names to some objects, and a QLineEdit lineEdit that allows me to specify the name of the object that I am looking for. It should run a function that is tested and working when I press a go button, with the input from the QComboBox and the lineEdit as arguments.

Here's the code for when the go button is clicked:

void gui::on_go_clicked(){
    std::string str(cb->currentText().toStdString());
    //std::cout << str << "\n";
    //QString qstr = lineEdit->text();
    //std::cout<<lineEdit->text().toStdString();
    updateDB(str, lineEdit->text().toStdString());
}

The first line, creating str, works fine. I.E. there's no problem with library functions or toStdString(). But when it executes my function, the program breaks, and it's not becuase of the function, it's because of the part where it tries to convert lineEdit->text().toStdString().

This is only when I write the word "test" in the lineEdit box. I've seen other answers talking about unicode, which I tried briefly, but I can assume that the user will not be putting any special characters in the lineEdit box, barring '_' and '.', which shouldn't be unicode.

Answer

Werner Erasmus picture Werner Erasmus · Aug 25, 2013

The first line, creating str, works fine. I.E. there's no problem with library functions or toStdString(). But when it executes my function, the program breaks, and it's not becuase of the function, it's because of the part where it tries to convert lineEdit->text().toStdString().

Simplify your test and verify that QString.toStdString() does what you expect:

Therefore:

QString text = "Precise text that user would input";
std::cout << text.toStdString() << std::endl; //or...
qDebug() << text.toStdString().c_str();

Is the expected result produced?

If this is the case, it means your function has a problem. How does the updateDB look (function signature?)? What are its inputs?

From Qt help files:

The Unicode data is converted into 8-bit characters using the toUtf8() function.

Therefore, if you haven't changed the locale of your widget (lineEdit) or it's parents, things should just work (or you should see something with information loss). I've used this function many times without trouble...