Why is FileStream not closed by XmlReader

c# .net idisposable xmlreader
TOMMY WANG picture TOMMY WANG · Mar 23, 2012 · Viewed 10k times · Source

So I am using the FileStream inside XmlReader

using (XmlReader reader = XmlReader.Create(new FileStream(archivePath, FileMode.Open), readerSettings))
{
    reader.close()
}

However, the file feed into the XmlReader is still in the lock state after the using scope, weird, I thought the XmlReader is going to close the FileStream for me, is it not?

Thanks for help.

Answer

Eric Patrick picture Eric Patrick · Nov 30, 2012

You should be able to control this through XmlReaderSettings.CloseInput.

readerSettings.CloseInput = true;
using (XmlReader reader = XmlReader.Create(new FileStream(archivePath, FileMode.Open), readerSettings))
{
    // do work with the reader
}

Or, more concisely if you don't care about other reader settings:

using (XmlReader reader = XmlReader.Create(new FileStream(archivePath, FileMode.Open), new XmlReaderSettings() { CloseInput = true }))
{
    // do work with the reader
}

Related questions

Proper use of the IDisposable interface

I know from reading the Microsoft documentation that the "primary" use of the IDisposable interface is to clean up unmanaged resources. To me, "unmanaged" means things like database connections, sockets, window handles, etc. But, I've seen code where the Dispose() …

Read More
Use of Finalize/Dispose method in C#

C# 2008 I have been working on this for a while now, and I am still confused about the use of finalize and dispose methods in code. My questions are below: I know that we only need a finalizer while disposing …

Read More
When should I use GC.SuppressFinalize()?

In .NET, under which circumstances should I use GC.SuppressFinalize()? What advantage(s) does using this method give me?

Read More