Can't set DialogResult in WPF

c# wpf modal-dialog dialogresult
quinnapi picture quinnapi · May 22, 2009 · Viewed 64.3k times · Source

I show a WPF window using ShowDialog() from the calling window. The window opens and is modal as expected. However, in my OK and Cancel button's click events in the dialog window I set this.DialogResult = true (or false) respectively, and the value does not get set. The window closes as expected, but DialogResult is still null.

Is this a bug in WPF? Or is there a reason the DialogResult property cannot be set yet does not throw an exception? The window is not hosted in a browser.

Code in the calling window: 

Window2 win = new Window2();
bool? result = win.ShowDialog();
if (result.HasValue && result.Value) {
   //never gets here because result is always null
}

Code in the dialog window:

this.DialogResult = true;

Answer

Dennis picture Dennis · May 25, 2009

DialogResult is a nullable bool. However you do not have to cast it to get it's value. 

bool? result = myWindow.ShowDialog();
if (result ?? false)
{
  // snip
}

The ?? sets the default value to return if the result is null. More information: Using Nullable Types (C# Programming Guide)

As for the original question, the only time I have seen and traced this issue is when the window was being disposed between setting the DialogResult and closing the window. Unfortunately the only advice that I can offer is for you step through your code and check the order of the operations. I believe that I "fixed" it by setting the DialogResult and then explicitly closing the window.

Related questions

Good or bad practice for Dialogs in wpf with MVVM?

I lately had the problem of creating add and edit dialogs for my wpf app. All I want to do in my code was something like this. (I mostly use viewmodel first approach with mvvm) ViewModel which calls a dialog …

Read More
How to correctly implement a modal dialog on top a non-modal dialog?

In a WPF application I would like to implement the following behaviour which doesn't seem to work straightforward: From the main window (Window1) the user opens a non-modal window (Window2), and that non-modal window may display a modal dialog (Window3). …

Read More
Metadata file '.dll' could not be found

I am working on a WPF, C# 3.0 project, and I get this error: Error 1 Metadata file 'WORK=- \Tools\VersionManagementSystem\BusinessLogicLayer\bin\Debug \BusinessLogicLayer.dll' could not be found C:\-=WORK=- \Tools \VersionManagementSystem\VersionManagementSystem\CSC VersionManagementSystem This is …

Read More