ReSharper complains when method can be static, but isn't

c# resharper static-methods
Andreas Grech picture Andreas Grech · Apr 26, 2009 · Viewed 8.8k times · Source

Why does ReSharper complain when a method can become static, but is not?

Is it because only one instance of a static method is created (on the type) and thus save on performance?

Answer

Brian Rasmussen picture Brian Rasmussen · Apr 26, 2009

I find that comment very useful as it points out two important things:

  1. It makes me ask myself if the method in question should actually be part of the type or not. Since it doesn't use any instance data, you should at least consider if it could be moved to its own type. Is it an integral part of the type, or is it really a general purpose utility method?

  2. If it does make sense to keep the method on the specific type, there's a potential performance gain as the compiler will emit different code for a static method.

Related questions

Method can be made static, but should it?

Resharper likes to point out multiple functions per asp.net page that could be made static. Does it help me if I do make them static? Should I make them static and move them to a utility class?

Read More
Virtual member call in a constructor

I'm getting a warning from ReSharper about a call to a virtual member from my objects constructor. Why would this be something not to do?

Read More
What are some alternatives to ReSharper?

I'm considering purchasing a ReSharper license, but are there any possible alternatives to ReSharper and how would you rate these compared to ReSharper? It doesn't necessarily have to be a free alternative, but I would just like to know how …

Read More