Extracting zip file in memory failing with C# DotNetZip

Charles Offenbacher picture Charles Offenbacher · Jun 16, 2011 · Viewed 7.3k times · Source

I'm trying to download and extract a zip file in C#, specifically DotNetZip.

When I run this code...

        HttpWebRequest webRequest = (HttpWebRequest)WebRequest.Create(reportUrl);
        HttpWebResponse response = (HttpWebResponse)webRequest.GetResponse();
        Stream stream = response.GetResponseStream();
        MemoryStream ms = new MemoryStream();

        stream.CopyTo(ms);
        ms.Seek(0, 0);
        ZipInputStream zip = new ZipInputStream(ms);
        zip.Seek(0, 0);

        ZipEntry e = zip.GetNextEntry();
        string s = e.FileName;

        MemoryStream ms2 = new MemoryStream();
        e.Extract(ms2);

After the Extract method executes, I get...

        $exception  {"Object reference not set to an instance of an object."}   System.Exception {System.NullReferenceException}

Any thoughts? Thanks!

Here's what the object looks like before the method runs

Answer

Darin Dimitrov picture Darin Dimitrov · Jun 16, 2011

It's difficult to say why your code doesn't work. I would start by simplifying it and ensuring that I am properly disposing all disposable resources such as streams:

class Program
{
    static void Main()
    {
        var url = "http://downloads.sourceforge.net/project/junit/junit/3.8.1/junit3.8.1.zip";
        using (var client = new WebClient())
        using (var zip = ZipFile.Read(client.DownloadData(url)))
        {
            foreach (var entry in zip)
            {
                entry.Extract(".");
            }        
        }
    }
}

Make sure you checkout the documentation for many useful examples of using the DotNetZip library.