I am having trouble with FxCop warning CA1006, Microsoft.Design "DoNotNestGenericTypesInMemberSignatures". Specifically, I am designing a ReportCollection<T>
class that inherits from ReadOnlyCollection<Report<T>>
, and its public
constructor takes an IList<Report<T>>
as a parameter.
The suggestion for fixing this warning is not very useful:
"To fix a violation of this rule, change the design to remove the nested type argument." There are two ways I can see so far to change the design as suggested:
internal
. This doesn't work in my case. The constructor must be public
because this collection class needs to be instantiable by code outside the assembly.Report<T>[]
instead of an IList<Report<T>>
. This is sub-optimal because external code should have the flexibility of using dynamically-sized data structures like List<T>
instead of fixed-size arrays.At this point, I have given up and suppressed this warning. Is there a better solution?
I would take FxCop's warnings as if they were suggestions from an extremely anal-retentive coworker. It's perfectly ok to ignore (suppress) some of the things it suggests.