C# Null propagating operator / Conditional access expression & if blocks

Philip Pittle picture Philip Pittle · Sep 4, 2014 · Viewed 21.8k times · Source

The Null propagating operator / Conditional access expression coming in looks like quite a handy feature. But I'm curious if it will help solve the problem of checking if a child member is not null and then calling a Boolean method on said child member inside an if block:

  public class Container<int>{
       IEnumerable<int> Objects {get;set;}
  }

  public Container BuildContainer()
  { 
      var c = new Container();

      if (/* Some Random Condition */)
         c.Objects = new List<int>{1,2,4};
  }

  public void Test()
  {
      var c = BuildContainer();

      //Old way
      if ( null != c && null != c.Objects && c.Objects.Any())
         Console.Write("Container has items!");


      //C# 6 way?
      if (c?.Object?.Any())
          Console.Write("Container has items!");
  }

Will c?.Object?.Any() compile? If the propagating operator short circuits (I assume that's the right term) to null then you have if (null), which isn't valid.

Will the C# team address this concern or am I missing the intended use case for the null propagating operator?

Answer

Eldar Dordzhiev picture Eldar Dordzhiev · Sep 4, 2014

It won't work this way. You can just skip the explanation and see the code below :)

As you know ?. operator will return null if a child member is null. But what happens if we try to get a non-nullable member, like the Any() method, that returns bool? The answer is that the compiler will "wrap" a return value in Nullable<>. For example, Object?.Any() will give us bool? (which is Nullable<bool>), not bool.

The only thing that doesn't let us use this expression in the if statement is that it can't be implicitly casted to bool. But you can do comparison explicitly, I prefer comparing to true like this:

if (c?.Object?.Any() == true)
    Console.Write("Container has items!");

Thanks to @DaveSexton there's another way:

if (c?.Object?.Any() ?? false)
    Console.Write("Container has items!");

But as for me, comparison to true seems more natural :)