How do I add an XElement to a document, avoiding the "incorrectly structured document" error?

Finglas picture Finglas · Jan 21, 2010 · Viewed 10.9k times · Source
        // Remove element with ID of 1
        var userIds = from user in document.Descendants("Id")
                       where user.Value == "1"
                       select user;

        userIds.Remove();

        SaveAndDisplay(document);

        // Add element back
        var newElement = new XElement("Id", "0", 
            new XElement("Balance", "3000"));
        document.Add(newElement);

        SaveAndDisplay(document);

The add element back block is the problem. As when it gets to the add it states:

This operation would create an incorrectly structured document.

What stupid mistake am I making?

Edit:

Yes, I was reading as an XDocument, not XElement. Any advice on when to favour one or the other?

Answer

Steve Guidi picture Steve Guidi · Jan 21, 2010

It looks like you are trying to add a new element as a child of your document's root. If so, then you need to change your Add statement to the following.

var newElement = new XElement("Id", "0", new XElement("Balanace", "3000"));
document.Root.Add(newElement);

Adding directly to the document adds another root element, which violates the XML structure.