DataAdapter: Update unable to find TableMapping['Table'] or DataTable 'Table'

Arif Ansari picture Arif Ansari · Oct 7, 2013 · Viewed 9.1k times · Source

This code snippet is throwing an error:

Update unable to find TableMapping['Table'] or DataTable 'Table'.) on adapter.Update(ds); line

Why it is throwing this type of error?

SqlConnection con = new SqlConnection();
con.ConnectionString = connectionString();

DataSet ds = new DataSet();

string strQuery = "SELECT * FROM Cars";
SqlDataAdapter adapter = new SqlDataAdapter();

adapter.SelectCommand = new SqlCommand(strQuery, con);

SqlCommandBuilder builder = new SqlCommandBuilder(adapter);

adapter.Fill(ds, "Cars");

//Code to modify data in the DataSet
ds.Tables["Cars"].Rows[0]["Brand"] = "NewBrand";

adapter.UpdateCommand = builder.GetUpdateCommand();
adapter.Update(ds);

Answer

Tim Schmelter picture Tim Schmelter · Oct 7, 2013

Use

adapter.Update(ds, "Cars");

instead.

I have tested it. I got the same error without and it works if i specify the tablename. However, i must admit that i yet don't know why the DataAdapter needs to know the table-name since it has all informations it needs. If i useds.GetChanges i get one row with the correct table-name.

Update I have found nothing on MSDN but finally found it in the source(ILSpy). Here is the implementation of DBDataAdapter.Update(DataSet):

public override int Update(DataSet dataSet)
{
    return this.Update(dataSet, "Table");
}

So if you don't specify a table, the table-name "Table" is used and if you've specified a table-name other than that you'll get this error, that's really strange!

I assume that the reason for this is that the DataAdapter cannot call GetChanges to determine the table to update for two reasons:

  1. It would be inefficient since it needs to loop all tables and all of their rows to find rows with a RowState != Unchanged
  2. It's possible that multiple tables needs to be updated since they contain changed rows. That is not supported via DataAdapter. Hence DataAdapter.Update(DataSet) assumes the default name "Table" as table-name.

Edit: However, maybe someone can explain me why the DataAdapter doesn't use DataSet.Tables[0].TableName instead.

So in general it seems to be best practise to specify the name of the table you want to update.