Attribute not valid on declaration type

Rob picture Rob · Oct 26, 2009 · Viewed 35.3k times · Source

I have the following code but I am getting the following compile errors:

Attribute 'WebPartStorage' is not valid on this declaration type. It is only valid on 'property, indexer' declarations.

AND

Attribute 'FriendlyName' is not valid on this declaration type. It is only valid on 'property, indexer' declarations.

I have modified my code from the MSDN article: https://docs.microsoft.com/en-us/previous-versions/office/developer/sharepoint2003/dd584174(v=office.11). Does anyone have any idea what I am doing wrong that is causing this error?

  [Category("Custom Properties")]
    [DefaultValue(RegionEnum.None)]
    [WebPartStorage(Storage.Shared)]
    [FriendlyName("Region")]
    [Description("Select a value from the dropdown list.")]
    [Browsable(true)]
    protected RegionEnum _Region;
    public RegionEnum Region
    {
        get
        {
            return _Region;
        }
        set
        {
            _Region = value;
        }
    }

Answer

Marc Gravell picture Marc Gravell · Oct 26, 2009

You seem to have attached the attribute to the field; attributes always adhere to the next thing (in this case, the field). You should re-order so that they adhere to the property instead of the field.

BTW; protected fields are rarely a good idea (they should be private); but especially if the property is public: what is the point?

protected RegionEnum _Region;
[Category("Custom Properties")]
[DefaultValue(RegionEnum.None)]
[WebPartStorage(Storage.Shared)]
[FriendlyName("Region")]
[Description("Select a value from the dropdown list.")]
[Browsable(true)]
public RegionEnum Region
{
    get { return _Region; }
    set { _Region = value; }
}