Running a simple LINQ query in parallel

Question

I'm still very new to LINQ and PLINQ. I generally just use loops and List.BinarySearch in a lot of cases, but I'm trying to get out of that mindset where I can.

public class Staff
{
  // ...
  public bool Matches(string searchString)
  {
    // ...
  }
}

Using "normal" LINQ - sorry, I'm unfamiliar with the terminology - I can do the following:

var matchedStaff = from s
                     in allStaff
                  where s.Matches(searchString)
                 select s;

But I'd like to do this in parallel:

var matchedStaff = allStaff.AsParallel().Select(s => s.Matches(searchString));

When I check the type of matchedStaff, it's a list of bools, which isn't what I want.

First of all, what am I doing wrong here, and secondly, how do I return a List<Staff> from this query?

public List<Staff> Search(string searchString)
{
  return allStaff.AsParallel().Select(/* something */).AsEnumerable();
}

returns IEnumerable<type>, not List<type>.

Answer 1

For your first question, you should just replace Select with Where :

var matchedStaff = allStaff.AsParallel().Where(s => s.Matches(searchString));

Select is a projection operator, not a filtering one, that's why you are getting an IEnumerable<bool> corresponding to the projection of all your Staff objects from the input sequence to bools returned by your Matches method call.

I understand it can be counter intuitive for you not to use select at all as it seems you are more familiar with the "query syntax" where select keyword is mandatory which is not the case using the "lambda syntax" (or "fluent syntax" ... whatever the naming), but that's how it is ;)

Projections operators, such a Select, are taking as input an element from the sequence and transform/projects this element somehow to another type of element (here projecting to bool type). Whereas filtering operators, such as Where, are taking as input an element from the sequence and either output the element as such in the output sequence or are not outputing the element at all, based on a predicate.

As for your second question, AsEnumerable returns an IEnumerable as it's name indicates ;) If you want to get a List<Staff> you should rather call ToList() (as it's name indicates ;)) :

return allStaff.AsParallel().Select(/* something */).ToList();

Hope this helps.