IndexOf too slow on list. Faster solution?

c# list performance indexof
NastyNateDoggy picture NastyNateDoggy · Jul 2, 2009 · Viewed 15.8k times · Source

I have generic list which must be a preserved order so I can retrieve the index of an object in the list. The problem is IndexOf is way too slow. If I comment the IndexOf out, the code runs fast as can be. Is there a better way, such as a preserved ordered hash list for c#?

Thanks, Nate

  • Edit - The order in which the items are added/inserted is the order it needs to be. No sorting on them is necessary. Also this list has the potential to be updated often, add, remove, insert. Basically I need to translate the object to an index due to them being represented in a grid control so I can perform operations on the grid control based on index.

Answer

Groo picture Groo · Jul 2, 2009

If it's not sorted, but the order needs to be preserved, then you could have a separate Dictionary<YourClass, int> which would contain the index for each element.

If you want a sorted list, then check previous posts - you can use SortedList<Tkey, TValue> in .Net 3.5, or sort it and use BinarySearch in older .Net versions.

[Edit] You can find similar examples on the web, e.g.: OrderedList. This one internally uses an ArrayList and a HashTable, but you can easily make it generic.

[Edit2] Ooops.. the example I gave you doesn't implement IndexOf the way I described at the beginning... But you get the point - one list should be ordered, the other one used for quick lookup.

Related questions

Check if a string contains an element from a list (of strings)

For the following block of code: For I = 0 To listOfStrings.Count - 1 If myString.Contains(lstOfStrings.Item(I)) Then Return True End If Next Return False The output is: Case 1: myString: C:\Files\myfile.doc listOfString: C:\Files\, C:\Files2\ …

Read More
Is there a performance impact when calling ToList()?

When using ToList(), is there a performance impact that needs to be considered? I was writing a query to retrieve files from a directory, which is the query: string[] imageArray = Directory.GetFiles(directory); However, since I like to work with …

Read More
Performance concern: StringCollection vs List<String>

I was wondering when I should use List< string > and when I should use StringCollection. Let's say that I have to deal with large number of strings (like text files of 10mb). I know that List< T &…

Read More