Why call base.OnActionExecuting(filterContext);?

asp.net-mvc asp.net-mvc-3 action-filter
chobo2 picture chobo2 · Jun 19, 2011 · Viewed 9.2k times · Source

I am just looking at some old code of mine and I have an action filter(OnActionExecuting method)

and at the end of it I have

 base.OnActionExecuting(filterContext);

Why searching around I see this quite a few times. I also see that in my old Authorize tag I call the base up.

Should I be always be calling the base methods after?

Answer

Darin Dimitrov picture Darin Dimitrov · Jun 19, 2011

Should I be always be calling the base methods after?

That will depend on the situation.

For example in authorization filters (deriving from AuthorizeAttribute) if you call the base method then all the existing authorization logic built into ASP.NET MVC will be executed. If you don't call it, only your authorization logic will be applied.

As far as other standard action filters are concerned (deriving from ActionFilterAttribute) all the OnActionExecuting, OnActionExecuted, OnResultExecuting and OnResultExecuted are defined as virtual but their body is empty, so it doesn't make any difference if you call or not the base method.

Related questions

In what order are filters executed in asp.net mvc

In MVC we can decorate action methods with different filters like [HttpPost] [Authorize] public ActionResult mymethod(){} HttpPost derives from MethodSelectorAttribute (probably indirectly) and the Authorize attribute inherits from ActionFilterAttribute. My question is: in which order are they executed in the …

Read More
Best place to set CurrentCulture for multilingual ASP.NET MVC web applications

For multilingual ASP.NET MVC 3 web application, I am determining the Thread.CurrentThread.CurrentCulture and Thread.CurrentThread.CurrentUICulture on the controller factory as follows: public class MyControllerFactory : DefaultControllerFactory { protected override IController GetControllerInstance(System.Web.Routing.RequestContext requestContext, Type controllerType) { //Get …

Read More
Get ActionName, ControllerName and AreaName and pass it in ActionFilter Attribute

I use a custom AuthorizationFilter like the followings: public class ActionAuthorizeAttribute : AuthorizeAttribute { protected override bool AuthorizeCore(System.Web.HttpContextBase httpContext) { if(!httpContext.User.Identity.IsAuthenticated) return false; if(IsUserExcluded()) return false; else return IsRoleAuthorize(httpContext); } } I use this filter at …

Read More