Deprecated PagerAdapter.instantiateItem() method

android android-pageradapter
Juan Andrés Diana picture Juan Andrés Diana · Dec 12, 2013 · Viewed 8.3k times · Source

I'm curious as to why instantiateItem was deprecated in favor of it's newer version. The change is that it now receives ViewGroup in stead of a more general View.

Deprecated method

public Object instantiateItem (View container, int position)

New method

public Object instantiateItem (ViewGroup container, int position)

Note: This change also happened to destroyItem, startUpdate, finishUpdate & setPrimaryItem.

Answer

Scott W picture Scott W · Dec 12, 2013

My guess is that it was done because those methods are always called with a ViewGroup rather than the more general View. As such, providing the parameter as a ViewGroup is a convenience, allowing developers to avoid always checking and casting the input. So instead of seeing this code over and over:

ViewGroup parent;
if (container instanceof ViewGroup) {
    parent = (ViewGroup) container;
}
else {
    throw new IllegalArgumentException("container must be a ViewGroup");
}

The implementer can simply use container directly.

And, in fact, you can see that this is exactly the reason in the commit message from Adam Powell:

Bug 5327146 - ViewPager API tweaks and docs

PagerAdapter previously took View instances as parameters to several of its methods leading to lots of casting to ViewGroup in adapter implementations.

Change these to take ViewGroups. Default implementation calls through to deprecated stubs with the existing signatures, allowing current adapters to keep working unmodified.

Related questions

Correctly implementing PagerAdapter in Android

I have problems with implementation of my custom PagerAdapter and using it with a ViewPager. This sample PagerAdapter has 10 items, every item is a button with it's index as text. When I run my program, I see a button with …

Read More
Destroy item from the ViewPager's adapter after screen orientation changed

So I'm having a problem with destroying (removing) one page from the ViewPager after the screen orientation changed. I'll try to describe the problem in the following lines. I'm using the FragmentStatePagerAdapter for the adapter of the ViewPager and a …

Read More
PagerAdapter.notifyDataSetChanged does not refresh fragments

My Activity contains a ViewPager and it's custom Adapter which extends FragmentStatePagerAdapter. ViewPager contains 3 fragments Code to remove Fragments from the ViewPager MainActivity public void deleteElement(){ final int currentItem = mViewPager.getCurrentItem(); mPagerAdapter.removeItem(currentItem); mPagerAdapter.notifyDataSetChanged(); } CustomPagerAdapter private ArrayList<…

Read More