GeoTagging Photo's after using Camera Intent

Question

I have an app that uses the Android Camera Intent to take pictures and after the picture is taken I am trying to add some gps data to the Image's Exif Data. However, my app keeps crashing when it reaches double longitude = location.getLongitude();

Here is my code :

         public void onCreate(Bundle savedInstanceState) 
            {
                super.onCreate(savedInstanceState);
                setContentView(R.layout.main);


                File folder = new File(Environment.getExternalStorageDirectory() + "/SApp");
                if(folder.exists() == false){
                    folder.mkdirs();
                }         

                setCamera();

            }


    private void setCamera(){
            Intent cameraIntent = new Intent(MediaStore.ACTION_IMAGE_CAPTURE);
            cameraIntent.putExtra(MediaStore.EXTRA_OUTPUT,Uri.fromFile(new File(Environment.getExternalStorageDirectory(),"/SApp/Attachment" + ".jpg")));
            startActivityForResult(cameraIntent, 1001);
        }

        protected void onActivityResult(int requestCode, int resultCode, Intent data){

            if(resultCode == RESULT_OK){

                LocationManager lm = (LocationManager)getSystemService(Context.LOCATION_SERVICE); 
                Location location = (Location) lm.getLastKnownLocation(LocationManager.GPS_PROVIDER);

                double longitude = location.getLongitude();
                double latitude = location.getLatitude();
                         File f = new File(Environment.getExternalStorageDirectory(),"/SApp/Attachment" + ".jpg");
                         geoTag(f.getAbsolutePath(),latitude,longitude);

        }
        }


public void geoTag(String filename, double latitude, double longitude){
    ExifInterface exif;

    try {
        exif = new ExifInterface(filename);
        int num1Lat = (int)Math.floor(latitude);
        int num2Lat = (int)Math.floor((latitude - num1Lat) * 60);
        double num3Lat = (latitude - ((double)num1Lat+((double)num2Lat/60))) * 3600000;

        int num1Lon = (int)Math.floor(longitude);
        int num2Lon = (int)Math.floor((longitude - num1Lon) * 60);
        double num3Lon = (longitude - ((double)num1Lon+((double)num2Lon/60))) * 3600000;

        exif.setAttribute(ExifInterface.TAG_GPS_LATITUDE, num1Lat+"/1,"+num2Lat+"/1,"+num3Lat+"/1000");
        exif.setAttribute(ExifInterface.TAG_GPS_LONGITUDE, num1Lon+"/1,"+num2Lon+"/1,"+num3Lon+"/1000");


        if (latitude > 0) {
            exif.setAttribute(ExifInterface.TAG_GPS_LATITUDE_REF, "N"); 
        } else {
            exif.setAttribute(ExifInterface.TAG_GPS_LATITUDE_REF, "S");
        }

        if (longitude > 0) {
            exif.setAttribute(ExifInterface.TAG_GPS_LONGITUDE_REF, "E");    
        } else {
        exif.setAttribute(ExifInterface.TAG_GPS_LONGITUDE_REF, "W");
        }

        exif.saveAttributes();
    } catch (IOException e) {
        Log.e("PictureActivity", e.getLocalizedMessage());
    } 

    }

ErrorTrace:

11-27 10:17:25.865: E/AndroidRuntime(27201): FATAL EXCEPTION: main
11-27 10:17:25.865: E/AndroidRuntime(27201): java.lang.RuntimeException: Failure delivering result ResultInfo{who=null, request=1001, result=-1, data=null} to activity {serverbased.app/serverbased.app.ServerAppActivity}: java.lang.NullPointerException
11-27 10:17:25.865: E/AndroidRuntime(27201):    at android.app.ActivityThread.deliverResults(ActivityThread.java:2994)
11-27 10:17:25.865: E/AndroidRuntime(27201):    at android.app.ActivityThread.handleSendResult(ActivityThread.java:3037)
11-27 10:17:25.865: E/AndroidRuntime(27201):    at android.app.ActivityThread.access$1100(ActivityThread.java:128)
11-27 10:17:25.865: E/AndroidRuntime(27201):    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1191)
11-27 10:17:25.865: E/AndroidRuntime(27201):    at android.os.Handler.dispatchMessage(Handler.java:99)
11-27 10:17:25.865: E/AndroidRuntime(27201):    at android.os.Looper.loop(Looper.java:137)
11-27 10:17:25.865: E/AndroidRuntime(27201):    at android.app.ActivityThread.main(ActivityThread.java:4514)
11-27 10:17:25.865: E/AndroidRuntime(27201):    at java.lang.reflect.Method.invokeNative(Native Method)
11-27 10:17:25.865: E/AndroidRuntime(27201):    at java.lang.reflect.Method.invoke(Method.java:511)
11-27 10:17:25.865: E/AndroidRuntime(27201):    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:980)
11-27 10:17:25.865: E/AndroidRuntime(27201):    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:747)
11-27 10:17:25.865: E/AndroidRuntime(27201):    at dalvik.system.NativeStart.main(Native Method)
11-27 10:17:25.865: E/AndroidRuntime(27201): Caused by: java.lang.NullPointerException
11-27 10:17:25.865: E/AndroidRuntime(27201):    at serverbased.app.ServerAppActivity.onActivityResult(ServerAppActivity.java:139)
11-27 10:17:25.865: E/AndroidRuntime(27201):    at android.app.Activity.dispatchActivityResult(Activity.java:4654)
11-27 10:17:25.865: E/AndroidRuntime(27201):    at android.app.ActivityThread.deliverResults(ActivityThread.java:2990)
11-27 10:17:25.865: E/AndroidRuntime(27201):    ... 11 more
11-27 10:17:39.794: I/Process(27201): Sending signal. PID: 27201 SIG: 9

Any Help would be appreciated!

Answer 1

You are incorrectly retrieving the Location. I would take a good look at this blog post: A Deep Dive Into Location. It will provide you with a number of best practices. Calling getLastKnownLocation is not going to start the location providers. The null return value indicates no value is available. You should use requestLocationUpdates. See snippet below:

LocationManager lm = (LocationManager) context.getSystemService(Context.LOCATION_SERVICE);

Criteria fineCriteria.setAccuracy(Criteria.ACCURACY_FINE);
String fineProvider = lm.getBestProvider(fineCriteria, true);

// Start the fine location listener
lm.requestLocationUpdates(fineProvider, 0, 0, locationListenerFine);

private LocationListener locationListenerFine = new LocationListener() {
    public void onLocationChanged(Location location) {

    }

    public void onProviderDisabled(String provider) {
    }

    public void onProviderEnabled(String provider) {
    }

    public void onStatusChanged(String provider, int status, Bundle extras) {
    }
};